LemmyNet
/
lemmy
3
2
Fork 3
Code Pull Requests 1 Releases Wiki Activity

Explicitly mark posts and comments as public (ref #1220) #167

Merged
dessalines merged 1 commits from comments-posts-public into main 2021-02-10 19:45:40 +00:00
Conversation 0 Commits 1 Files Changed 3 +35 -19
nutomic commented 2021-02-10 13:02:20 +00:00
Owner
Copy Link

As discussed in #1220 (comment).

As discussed in [#1220 (comment)](https://github.com/LemmyNet/lemmy/issues/1220#issuecomment-776306378).
nutomic added 1 commit 2021-02-10 13:02:24 +00:00
dessalines reviewed 2021-02-10 18:31:11 +00:00
crates/apub/src/objects/mod.rs
@ -227,0 +240,4 @@
.map(|a| a.as_xsd_any_uri().context(location_info!()))
.collect::<Result<Vec<&Url>, anyhow::Error>>()?;
for cid in community_ids {
let community = get_or_fetch_and_upsert_community(&cid, context, request_counter).await;
dessalines commented 2021-02-10 18:31:11 +00:00
Owner
Copy Link

I'm confused about this. Now a post is addressed to the community, and public, but public isn't upsertable. What happen when it encounters public() in this loop?

I'm confused about this. Now a post is addressed to the community, and public, but public isn't upsertable. What happen when it encounters `public()` in this loop?
nutomic commented 2021-02-10 19:30:44 +00:00
Author
Owner
Copy Link

It returns an Err and doesn't go into the if below, so the value is skipped.

It returns an Err and doesn't go into the if below, so the value is skipped.
dessalines marked this conversation as resolved
dessalines merged commit f899831ed3 into main 2021-02-10 19:45:40 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: LemmyNet/lemmy#167
No description provided.
Delete Branch "comments-posts-public"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?