LemmyNet
/
lemmy
3
2
Fork 3
Code Pull Requests 1 Releases Wiki Activity

WIP: Try to implement federated user deletion (fixes #1284) #144

Closed
nutomic wants to merge 2 commits from federated-user-delete into main
pull from: federated-user-delete
merge into: LemmyNet:main
Conversation 3 Commits 2 Files Changed 8 +76 -10
nutomic commented 2020-11-27 16:51:03 +00:00
Owner
Copy Link

This is a lot more complicated than I thought. Main problem is that we need to address the delete activity to some specific actors. We might address it to all communities where the user posted, but our inbox cant receive the same activity in more than one community.

In fact a cleaner solution might be creating a special lemmy actor which represents the whole instance, and receives this Delete/User. But of course thats also more complicated to implement.

This is a lot more complicated than I thought. Main problem is that we need to address the delete activity to some specific actors. We might address it to all communities where the user posted, but our inbox cant receive the same activity in more than one community. In fact a cleaner solution might be creating a special `lemmy` actor which represents the whole instance, and receives this `Delete/User`. But of course thats also more complicated to implement.
dessalines commented 2020-11-27 20:34:29 +00:00
Owner
Copy Link

but our inbox cant receive the same activity in more than one community.

I think that's only really a problem for the websocket events like comments and mentions, where it was posting to both a community inbox and a user inbox.

It'd probably be safest to send their user delete to all their subscribed communities. If that really can't work then we could de-dupe that by instance.

> but our inbox cant receive the same activity in more than one community. I think that's only really a problem for the websocket events like comments and mentions, where it was posting to both a community inbox and a user inbox. It'd probably be safest to send their user delete to all their subscribed communities. If that really can't work then we could de-dupe that by instance.
dessalines commented 2020-11-30 19:17:22 +00:00
Owner
Copy Link

Is this one ready to be tested yet?

Is this one ready to be tested yet?
nutomic commented 2020-11-30 20:53:35 +00:00
Author
Owner
Copy Link

Not at all, I'm still not sure whats a good way to handle this. Handling it on the instance level (with a special lemmy actor for each instance) seems like the cleanest solution. It would also help to do things like disable downvotes for the entire instance.

Not at all, I'm still not sure whats a good way to handle this. Handling it on the instance level (with a special `lemmy` actor for each instance) seems like the cleanest solution. It would also help to do things like disable downvotes for the entire instance.
👍 1
nutomic closed this pull request 2020-12-16 15:39:26 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: LemmyNet/lemmy#144
No description provided.
Delete Branch "federated-user-delete"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?