LemmyNet
/
lemmy
3
2
Fork 3
Code Pull Requests 1 Releases Wiki Activity

Set valid context for our extra fields (ref #1220) #142

Merged
dessalines merged 1 commits from apub-context into main 2020-11-27 20:28:54 +00:00
Conversation 0 Commits 1 Files Changed 17 +83 -55
nutomic commented 2020-11-25 17:47:41 +00:00
Owner
Copy Link
No description provided.
dessalines reviewed 2020-11-27 18:34:53 +00:00
lemmy_apub/src/extensions/context.rs
@ -0,0 +11,4 @@
"stickied": "as:stickied",
"comments_enabled": {
"kind": "sc:Boolean",
"id": "pt:commentsEnabled"
dessalines commented 2020-11-27 18:34:53 +00:00
Owner
Copy Link

What's this about here?

What's this about here?
nutomic commented 2020-11-27 19:04:07 +00:00
Author
Owner
Copy Link

We use the commentsEnabled field for locked posts. The pt: probably stands for Peertube cause thats where I copied it from. Dont know if we need to define that, or change it to some Lemmy namespace.

We use the `commentsEnabled` field for locked posts. The `pt:` probably stands for Peertube cause thats where I copied it from. Dont know if we need to define that, or change it to some Lemmy namespace.
dessalines reviewed 2020-11-27 18:36:28 +00:00
lemmy_apub/src/extensions/context.rs
@ -0,0 +5,4 @@
pub(crate) fn lemmy_context() -> Result<Vec<AnyBase>, LemmyError> {
let context_ext = AnyBase::from_arbitrary_json(json!(
{
"sc": "http://schema.org#",
dessalines commented 2020-11-27 18:36:28 +00:00
Owner
Copy Link

Does this need to be https://lemmy.ml#schema or something

Does this need to be `https://lemmy.ml#schema` or something
nutomic commented 2020-11-27 19:05:33 +00:00
Author
Owner
Copy Link

I copied it directly from the Peertube json:

curl -H "Accept: application/activity+json" https://peertube.social/videos/watch/2c8aa3bb-e13f-40ef-a397-01c9696a8d43 | jq

I copied it directly from the Peertube json: `curl -H "Accept: application/activity+json" https://peertube.social/videos/watch/2c8aa3bb-e13f-40ef-a397-01c9696a8d43 | jq`
dessalines commented 2020-11-27 20:28:39 +00:00
Owner
Copy Link

Cool, looks good to me then.

Cool, looks good to me then.
dessalines merged commit 050ca88085 into main 2020-11-27 20:28:54 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: LemmyNet/lemmy#142
No description provided.
Delete Branch "apub-context"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?