Dont handle activities twice in inbox #133

nutomic · 2020-11-16T20:53:45Z

nutomic commented

2020-11-16 20:53:45 +00:00

This works fine, and should fix the problem with duplicate websocket notifications (it notified only once in my quick, local test).

For some reason I dont understand, this test is failing (but locking a post federates fine if I try it manually).

● Lock a post

TypeError: Cannot read property 'community_local' of undefined

218 |   let searchBeta2 = await searchPost(beta, postRes.post);
219 |   let betaPost2 = searchBeta2.posts[0];
> 220 |   expect(betaPost2.community_local).toBe(true);
|                    ^
221 |   expect(betaPost2.creator_local).toBe(false);
222 |   expect(betaPost2.locked).toBe(false);
223 |

at src/post.spec.ts:220:20
at step (src/post.spec.ts:33:23)
at Object.next (src/post.spec.ts:14:53)
at fulfilled (src/post.spec.ts:5:58)
at processTicksAndRejections (node:internal/process/task_queues:93:5)

This works fine, and should fix the problem with duplicate websocket notifications (it notified only once in my quick, local test). For some reason I dont understand, this test is failing (but locking a post federates fine if I try it manually). ``` ● Lock a post TypeError: Cannot read property 'community_local' of undefined 218 | let searchBeta2 = await searchPost(beta, postRes.post); 219 | let betaPost2 = searchBeta2.posts[0]; > 220 | expect(betaPost2.community_local).toBe(true); | ^ 221 | expect(betaPost2.creator_local).toBe(false); 222 | expect(betaPost2.locked).toBe(false); 223 | at src/post.spec.ts:220:20 at step (src/post.spec.ts:33:23) at Object.next (src/post.spec.ts:14:53) at fulfilled (src/post.spec.ts:5:58) at processTicksAndRejections (node:internal/process/task_queues:93:5) ```

dessalines commented

2020-11-17 14:29:31 +00:00

I might need to add some more waits in there, but it passed on travis.

https://travis-ci.org/github/LemmyNet/lemmy/builds/744039711

I might need to add some more waits in there, but it passed on travis. https://travis-ci.org/github/LemmyNet/lemmy/builds/744039711

dessalines commented

2020-11-17 15:43:06 +00:00

I tested, this fixed it.

dessalines referenced this issue from a commit

2020-11-17 15:43:12 +00:00

Merge pull request 'Dont handle activities twice in inbox' (#133) from inbox-deduplicate-handling into main Reviewed-on: https://yerbamate.ml/LemmyNet/lemmy/pulls/133

dessalines merged commit eb690fc39c into main