LemmyNet
/
lemmy
3
2
Fork 3
Code Pull Requests 1 Releases Wiki Activity

Add pending status for federated follows #130

Merged
dessalines merged 2 commits from pending-follow into main 2020-11-11 19:18:29 +00:00
Conversation 0 Commits 2 Files Changed 25 +109 -57
nutomic commented 2020-11-10 15:51:31 +00:00
Owner
Copy Link

I havent tested the malicious case, but normal, local and remote follows are working fine.

Edit: Also added a commit to fix the tests, but there are some complicated errors around CommunityFollower.

I havent tested the malicious case, but normal, local and remote follows are working fine. Edit: Also added a commit to fix the tests, but there are some complicated errors around `CommunityFollower`.
nutomic changed title from Add pending status for federated follows to WIP: Add pending status for federated follows 2020-11-10 16:05:08 +00:00
nutomic reviewed 2020-11-10 16:09:25 +00:00
lemmy_db/src/community.rs
@ -298,0 +308,4 @@
.filter(user_id.eq(user_id_)),
)
.set(pending.eq(true))
.get_result::<Self>(conn)
nutomic commented 2020-11-10 16:09:25 +00:00
Author
Owner
Copy Link

Not sure if this is correct, it should throw an error if no such row was found.

Not sure if this is correct, it should throw an error if no such row was found.
dessalines commented 2020-11-10 16:29:39 +00:00
Owner
Copy Link

Not totally sure, but it follows the convention of the others. I think since its Result<Self, Error>, that it will either be the single row, or an error if nothing got updated.

Not totally sure, but it follows the convention of the others. I think since its Result<Self, Error>, that it will either be the single row, or an error if nothing got updated.
nutomic changed title from WIP: Add pending status for federated follows to Add pending status for federated follows 2020-11-11 16:11:03 +00:00
dessalines merged commit 15c77f85c1 into main 2020-11-11 19:18:29 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: LemmyNet/lemmy#130
No description provided.
Delete Branch "pending-follow"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?