LemmyNet
/
lemmy
3
2
Fork 3
Code Pull Requests 1 Releases Wiki Activity

Dont send email notifications to banned users (fixes #1251) #126

Merged
dessalines merged 2 commits from dont-email-banned-user into main 2020-11-05 19:14:52 +00:00
Conversation 3 Commits 2 Files Changed 2 +41 -53
nutomic commented 2020-11-05 12:44:45 +00:00
Owner
Copy Link

Havent tested this yet.

Havent tested this yet.
dessalines commented 2020-11-05 13:47:50 +00:00
Owner
Copy Link

I'd rather do this instead: https://github.com/LemmyNet/lemmy/issues/1255

Reason, a banned user might want to remove their email, matrix id, change their bio to remove identifying info, etc.

I'd rather do this instead: https://github.com/LemmyNet/lemmy/issues/1255 Reason, a banned user might want to remove their email, matrix id, change their bio to remove identifying info, etc.
nutomic commented 2020-11-05 15:14:57 +00:00
Author
Owner
Copy Link

Regardless, there is no reason to send an email notification to a user who is banned and cant reply to the comment anyway. And I'm sure that not everyone is going to manually remove their email after being banned (they might not know that its possible).

I forgot to do the same change for private message notifications, best squash before merging.

Regardless, there is no reason to send an email notification to a user who is banned and cant reply to the comment anyway. And I'm sure that not everyone is going to manually remove their email after being banned (they might not know that its possible). I forgot to do the same change for private message notifications, best squash before merging.
dessalines commented 2020-11-05 19:14:44 +00:00
Owner
Copy Link

Gotcha, I agree, plus you cleaned up my repeated code here too.

Gotcha, I agree, plus you cleaned up my repeated code here too.
dessalines merged commit 60517f8471 into main 2020-11-05 19:14:52 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: LemmyNet/lemmy#126
No description provided.
Delete Branch "dont-email-banned-user"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?