LemmyNet
/
lemmy
3
2
Fork 3
Code Pull Requests 1 Releases Wiki Activity

Fix federation of community removal/deletion, added docs #125

Merged
dessalines merged 3 commits from community-deletion-federate into main 2020-11-05 20:19:07 +00:00
Conversation 1 Commits 3 Files Changed 9 +166 -76
nutomic commented 2020-11-05 12:21:14 +00:00
Owner
Copy Link

Here we go, community deletion and removal are working fine now. There was a problem because Lemmy on the receiving side would refetch the community to confirm the signature etc, but this would fail because the community was already deleted. I worked around this by returning the community from the database if the fetch failed. This obviously causes some errors to be logged.

Also I noticed that /c/main/followers and /c/main/outbox are still served even after the community is deleted. Havent changed that yet because I dont want to break another thing.

Here we go, community deletion and removal are working fine now. There was a problem because Lemmy on the receiving side would refetch the community to confirm the signature etc, but this would fail because the community was already deleted. I worked around this by returning the community from the database if the fetch failed. This obviously causes some errors to be logged. Also I noticed that `/c/main/followers` and `/c/main/outbox` are still served even after the community is deleted. Havent changed that yet because I dont want to break another thing.
dessalines commented 2020-11-05 13:49:05 +00:00
Owner
Copy Link

I'll try to write a test for this now.

edit: looks like I had one, the tests were just commented out.

I'll try to write a test for this now. edit: looks like I had one, the tests were just commented out.
dessalines merged commit b7d2dac9bf into main 2020-11-05 20:19:07 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: LemmyNet/lemmy#125
No description provided.
Delete Branch "community-deletion-federate"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?