LemmyNet
/
lemmy
3
2
Fork 3
Code Pull Requests 1 Releases Wiki Activity

Add missing docs for community activities (fixes #1250) #124

Closed
nutomic wants to merge 1 commits from community-activities-docs into main
pull from: community-activities-docs
merge into: LemmyNet:main
Conversation 2 Commits 1 Files Changed 2 +52 -7
nutomic commented 2020-11-04 17:19:45 +00:00
Owner
Copy Link

I also noticed that community delete was sending the full community json, so I changed that to send the ID instead.

One more problem, I'm consistently getting Invalid signature on request: /inbox for all these Undo, Delete, Remove community activities (with the local setup). Posts and comments are received fine though. This is before the changes in #123. Code looks fine though, can you reproduce it?

Edit: Same problem with Delete etc on our test instances:
https://enterprise.lemmy.ml/c/testcom
https://voyager.lemmy.ml/community/163

I also noticed that community delete was sending the full community json, so I changed that to send the ID instead. One more problem, I'm consistently getting `Invalid signature on request: /inbox` for all these Undo, Delete, Remove community activities (with the local setup). Posts and comments are received fine though. This is before the changes in #123. Code looks fine though, can you reproduce it? Edit: Same problem with Delete etc on our test instances: https://enterprise.lemmy.ml/c/testcom https://voyager.lemmy.ml/community/163
nutomic commented 2020-11-04 17:40:55 +00:00
Author
Owner
Copy Link

Please wait for https://github.com/LemmyNet/lemmy/issues/1253 before merging cause I might have to adjust the actor for these activities.

Edit: I also forgot to update the ToC.

Please wait for https://github.com/LemmyNet/lemmy/issues/1253 before merging cause I might have to adjust the actor for these activities. Edit: I also forgot to update the ToC.
nutomic commented 2020-11-05 12:09:46 +00:00
Author
Owner
Copy Link

Gonna make a new PR for this.

Gonna make a new PR for this.
nutomic closed this pull request 2020-11-05 12:09:46 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: LemmyNet/lemmy#124
No description provided.
Delete Branch "community-activities-docs"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?