LemmyNet
/
lemmy
3
2
Fork 3
Code Pull Requests 1 Releases Wiki Activity

In comment create/update, include parent creator in cc (ref #698) #122

Merged
dessalines merged 1 commits from comment-parent-cc into main 2020-10-27 16:15:22 +00:00
Conversation 1 Commits 1 Files Changed 2 +28 -8
nutomic commented 2020-10-27 13:55:28 +00:00
Owner
Copy Link

They should be notified directly, in case they are not a community follower (same as mentions basically).

They should be notified directly, in case they are not a community follower (same as mentions basically).
nutomic reviewed 2020-10-27 13:57:27 +00:00
lemmy_apub/src/activities/send/comment.rs Outdated
@ -323,3 +322,3 @@
context: &LemmyContext,
) -> Result<MentionsAndAddresses, LemmyError> {
let mut addressed_ccs = vec![community.get_followers_url()?];
let mut addressed_ccs = vec![];
nutomic commented 2020-10-27 13:57:27 +00:00
Author
Owner
Copy Link

I removed this because the create/update contained both the community and community followers as cc. I dont think that makes sense, so I removed this, meaning only the community is in the cc (along with any mentions and the parent post/comment creator).

I removed this because the create/update contained both the community and community followers as cc. I dont think that makes sense, so I removed this, meaning only the community is in the cc (along with any mentions and the parent post/comment creator).
dessalines commented 2020-10-27 14:07:40 +00:00
Owner
Copy Link

Seems fine, as long as the CI passes.

Seems fine, as long as the CI passes.
nutomic commented 2020-10-27 15:53:29 +00:00
Author
Owner
Copy Link

I already ran the tests locally, everything passed. Just give me one moment to add some rustdoc and adjust the documentation.

I already ran the tests locally, everything passed. Just give me one moment to add some rustdoc and adjust the documentation.
nutomic commented 2020-10-27 15:59:22 +00:00
Author
Owner
Copy Link

Force pushed the docs changes, without changing anything else in the code.

Force pushed the docs changes, without changing anything else in the code.
dessalines merged commit e95ca66c9f into main 2020-10-27 16:15:22 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: LemmyNet/lemmy#122
No description provided.
Delete Branch "comment-parent-cc"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?