LemmyNet
/
lemmy
3
2
Fork 3
Code Pull Requests 1 Releases Wiki Activity

Ignore incoming activities which have been received before, add /activities endpoint #118

Merged
dessalines merged 2 commits from activity-checks into main 2020-10-27 16:26:18 +00:00
Conversation 4 Commits 2 Files Changed 21 +207 -95
nutomic commented 2020-10-23 13:10:13 +00:00
Owner
Copy Link

The first commit should be pretty clear. This is required by the Activitypub standard, and also helps to simplify our code a bit.

The /activities endpoint is also straightforward, but there is one problem: it will return activities related to private messages or Follow/Accept. We need to add some way to exclude those, maybe a column sensitive on the activity table?

Also this change does not prevent periodically clearing out the activity table. The changes here are only important for new activities, so if those over 1 month old or so are deleted, everything will still work fine. The inbox would throw an error instead of http 200 if somehow an old activity were delivered, and the http endpoint would not find old activities. But those are very minor problems.

The first commit should be pretty clear. This is required by the Activitypub standard, and also helps to simplify our code a bit. The `/activities` endpoint is also straightforward, but there is one problem: it will return activities related to private messages or `Follow`/`Accept`. We need to add some way to exclude those, maybe a column `sensitive` on the activity table? Also this change does not prevent periodically clearing out the activity table. The changes here are only important for new activities, so if those over 1 month old or so are deleted, everything will still work fine. The inbox would throw an error instead of http 200 if somehow an old activity were delivered, and the http endpoint would not find old activities. But those are very minor problems.
dessalines commented 2020-10-24 15:37:59 +00:00
Owner
Copy Link

For some reason this failed in travis, I restarted the job just to make sure.

For some reason this failed in travis, I restarted the job just to make sure.
nutomic commented 2020-10-26 11:55:41 +00:00
Author
Owner
Copy Link

Forgot to add the migration, fixed now.

Forgot to add the migration, fixed now.
dessalines reviewed 2020-10-27 16:22:18 +00:00
lemmy_apub/src/inbox/mod.rs
@ -4,0 +32,4 @@
.await?;
match existing {
Ok(_) => Ok(true),
Err(_) => Ok(false),
dessalines commented 2020-10-27 16:22:18 +00:00
Owner
Copy Link

This works, but seems like it'd be easier to just return existing.

This works, but seems like it'd be easier to just return existing.
dessalines commented 2020-10-27 16:25:39 +00:00
Owner
Copy Link

Looks good to me, and tests passed so I'll merge.

Looks good to me, and tests passed so I'll merge.
dessalines merged commit 3bf885329d into main 2020-10-27 16:26:18 +00:00
nutomic commented 2020-10-28 11:11:17 +00:00
Author
Owner
Copy Link

We still need to fix the problem that private message and follow activities are available over HTTP without authentification.

We still need to fix the problem that private message and follow activities are available over HTTP without authentification.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: LemmyNet/lemmy#118
No description provided.
Delete Branch "activity-checks"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?