LemmyNet
/
lemmy
3
2
Fork 3
Code Pull Requests 1 Releases Wiki Activity

Dont allow localhost or raw IPs in activitypub IDs (ref #1221) #116

Merged
dessalines merged 1 commits from disallow-localhost-urls into main 2020-10-22 18:55:13 +00:00
Conversation 0 Commits 1 Files Changed 1 +7
nutomic commented 2020-10-22 16:14:12 +00:00
Owner
Copy Link
No description provided.
dessalines reviewed 2020-10-22 17:06:47 +00:00
lemmy_apub/src/lib.rs
@ -74,1 +75,4 @@
let host = apub_id.host_str().context(location_info!())?;
let host_as_ip = host.parse::<IpAddr>();
if host == "localhost" || host_as_ip.is_ok() {
dessalines commented 2020-10-22 17:06:47 +00:00
Owner
Copy Link

I spose the tests will fail if this doesn't work as it should.

I spose the tests will fail if this doesn't work as it should.
dessalines merged commit de8d8542b4 into main 2020-10-22 18:55:12 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: LemmyNet/lemmy#116
No description provided.
Delete Branch "disallow-localhost-urls"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?