Organise activity receive files by object type, not by activity type #115

nutomic · 2020-10-21T19:56:21Z

nutomic commented

2020-10-21 19:56:21 +00:00

I think it makes much more sense this way, because sending and receiving are organised in the same way now. And by moving the routing into the inbox, it should be a bit easier and more logical to handle all activities in user/community inboxes as well.

Only disadvantage is that the files are longer now (which is also why I left post_undo and comment_undo as separate files).

There are no logic changes, only functions moved around. Federation tests are passing.

I think it makes much more sense this way, because sending and receiving are organised in the same way now. And by moving the routing into the inbox, it should be a bit easier and more logical to handle all activities in user/community inboxes as well. Only disadvantage is that the files are longer now (which is also why I left `post_undo` and `comment_undo` as separate files). There are no logic changes, only functions moved around. Federation tests are passing.

dessalines referenced this issue from a commit

2020-10-22 18:55:30 +00:00

Merge pull request 'Organise activity receive files by object type, not by activity type' (#115) from inbox-refactoring-2 into main Reviewed-on: https://yerbamate.dev/LemmyNet/lemmy/pulls/115

dessalines merged commit 73ccbb1bc8 into main

2020-10-22 18:55:30 +00:00

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: LemmyNet/lemmy#115