LemmyNet
/
lemmy
3
2
Fork 3
Code Pull Requests 1 Releases Wiki Activity

Also return json for long accept header with profile link (ref #1216) #114

Merged
dessalines merged 1 commits from json-headers into main 2020-10-21 16:33:35 +00:00
Conversation 0 Commits 1 Files Changed 1 +7 -1
nutomic commented 2020-10-21 13:53:20 +00:00
Owner
Copy Link

Tested and works with both accept headers.

Tested and works with both accept headers.
dessalines reviewed 2020-10-21 14:58:16 +00:00
src/routes/federation.rs
@ -14,2 +14,4 @@
use sha2::{Digest, Sha256};
static APUB_JSON_CONTENT_TYPE_LONG: &str =
"application/ld+json; profile=\"https://www.w3.org/ns/activitystreams\"";
dessalines commented 2020-10-21 14:58:04 +00:00
Owner
Copy Link

Why not move this to the lib.rs right below the other one, or that one here.

Why not move this to the lib.rs right below the other one, or that one here.
nutomic commented 2020-10-21 15:01:23 +00:00
Author
Owner
Copy Link

The other one is also used for outgoing requests, so its reasonable to have it as a public var. This one is only used here, so I'm not sure if that makes sense. But I can change it if you want.

The other one is also used for outgoing requests, so its reasonable to have it as a public var. This one is only used here, so I'm not sure if that makes sense. But I can change it if you want.
dessalines commented 2020-10-21 15:02:39 +00:00
Owner
Copy Link

Ah, that's fine then. I'll just wait for it to pass then merge.

https://travis-ci.org/github/LemmyNet/lemmy/builds/737740876

Ah, that's fine then. I'll just wait for it to pass then merge. https://travis-ci.org/github/LemmyNet/lemmy/builds/737740876
dessalines merged commit 3e22c99c96 into main 2020-10-21 16:33:35 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: LemmyNet/lemmy#114
No description provided.
Delete Branch "json-headers"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?