LemmyNet
/
lemmy
3
2
Fork 3
Code Pull Requests 1 Releases Wiki Activity

Remove hardcoded usage of https #108

Manually merged
LemmyNet merged 3 commits from remove-hardcoded-https into main 2020-10-01 17:57:30 +00:00
Conversation 3 Commits 3 Files Changed 20 +146 -93
nutomic commented 2020-09-25 15:35:18 +00:00
Owner
Copy Link

Havent tested this but it should be pretty straightforward.

Havent tested this but it should be pretty straightforward.
dessalines commented 2020-09-25 21:37:01 +00:00
Owner
Copy Link

https://travis-ci.org/github/LemmyNet/lemmy/builds/730299729

Hard to say why the tests failed, looks like everything is correctly using http and not https. I looked in the tests and I can't find any reference to https either.

https://travis-ci.org/github/LemmyNet/lemmy/builds/730299729 Hard to say why the tests failed, looks like everything is correctly using http and not https. I looked in the tests and I can't find any reference to https either.
nutomic commented 2020-09-28 11:55:25 +00:00
Author
Owner
Copy Link

I tried it locally and also get some test failures, but they are completely different from the ones failing in Travis. Whats more, running the tests multiple times gives completely different failures. In two test runs, I had a failure in "Remove a post from admin and community on same instance" (and nothing else). In another run, I had two failures in comment.spec.ts (and nothing else).

Really sucks that the tests are so inconsistent. What do you think about bypassing the activity queue for test runs? Thats where these problems started iirc.

I tried it locally and also get some test failures, but they are completely different from the ones failing in Travis. Whats more, running the tests multiple times gives completely different failures. In two test runs, I had a failure in "Remove a post from admin and community on same instance" (and nothing else). In another run, I had two failures in comment.spec.ts (and nothing else). Really sucks that the tests are so inconsistent. What do you think about bypassing the activity queue for test runs? Thats where these problems started iirc.
dessalines commented 2020-09-28 15:05:25 +00:00
Owner
Copy Link

Its annoying that they can be pretty inconsistent locally, but at least on travis they do seem pretty consistent. With this one it tells me we have an error in our logic somewhere, or with the travis config, since all the comment and post tests are failing. I don't wanna bypass the queue (and do something synchronous) for the tests, because its different from prod, because the tests have been pretty stable on travis at least: https://travis-ci.org/github/LemmyNet/lemmy/builds

Its annoying that they can be pretty inconsistent locally, but at least on travis they do seem pretty consistent. With this one it tells me we have an error in our logic somewhere, or with the travis config, [since all the comment and post tests are failing.](https://travis-ci.org/github/LemmyNet/lemmy/builds/730299729#L1123) I don't wanna bypass the queue (and do something synchronous) for the tests, because its different from prod, because the tests have been pretty stable on travis at least: https://travis-ci.org/github/LemmyNet/lemmy/builds
LemmyNet manually merged commit 4772cbd23f into main 2020-10-01 17:57:30 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: LemmyNet/lemmy#108
No description provided.
Delete Branch "remove-hardcoded-https"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?