LemmyNet
/
lemmy
3
2
Fork 3
Code Pull Requests 1 Releases Wiki Activity

Dont federate embeds, but refetch them for security #106

Merged
dessalines merged 1 commits from dont-federate-embeds into main 2020-09-24 17:43:44 +00:00
Conversation 2 Commits 1 Files Changed 7 +200 -258
nutomic commented 2020-09-22 14:46:06 +00:00
Owner
Copy Link

Tested it locally, and embeds were working perfectly fine on the receiving instance.

Tested it locally, and embeds were working perfectly fine on the receiving instance.
nutomic commented 2020-09-22 19:01:24 +00:00
Author
Owner
Copy Link

Didn't work, it creates urls like : https://enterprise.lemmy.ml/pictrs/image/thumbnail256/https://i.ytimg.com/vi/Wl959QnD3lM/maxresdefault.jpg .
It needs to be fully re-cached into the local pictrs
Basically the same way the API does it
so just use fetch_iframely_and_pictrs_data() instead?
I think so, but look how the flow works in API.

> Didn't work, it creates urls like : https://enterprise.lemmy.ml/pictrs/image/thumbnail256/https://i.ytimg.com/vi/Wl959QnD3lM/maxresdefault.jpg . > It needs to be fully re-cached into the local pictrs > Basically the same way the API does it > so just use fetch_iframely_and_pictrs_data() instead? > I think so, but look how the flow works in API.
nutomic changed title from Dont federate embeds, but refetch them for security to WIP: Dont federate embeds, but refetch them for security 2020-09-22 19:01:35 +00:00
nutomic changed title from WIP: Dont federate embeds, but refetch them for security to Dont federate embeds, but refetch them for security 2020-09-24 15:49:55 +00:00
nutomic commented 2020-09-24 15:51:59 +00:00
Author
Owner
Copy Link

Updated. It uses the same code as post creation in the api now. Both pictrs links and those with iframely preview are working fine.

Updated. It uses the same code as post creation in the api now. Both pictrs links and those with iframely preview are working fine.
dessalines merged commit bfed8a8be4 into main 2020-09-24 17:43:44 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: LemmyNet/lemmy#106
No description provided.
Delete Branch "dont-federate-embeds"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?