From c422b88cf81822d241e4fbc55d86312db5b57576 Mon Sep 17 00:00:00 2001
From: Felix Ableitner <me@nutomic.com>
Date: Fri, 13 Sep 2024 22:55:24 +0200
Subject: [PATCH] Add test case to find errors that are only used for
 federation

---
 crates/utils/src/error.rs              |  1 +
 crates/utils/tests/test_errors_used.rs | 24 +++++++++++++++++++-----
 2 files changed, 20 insertions(+), 5 deletions(-)

diff --git a/crates/utils/src/error.rs b/crates/utils/src/error.rs
index d805ecf0f..af0629e43 100644
--- a/crates/utils/src/error.rs
+++ b/crates/utils/src/error.rs
@@ -23,6 +23,7 @@ pub enum LemmyErrorType {
   CouldntUpdateComment,
   CouldntUpdatePrivateMessage,
   CannotLeaveAdmin,
+  // TODO: also remove the translations of unused errors
   PictrsResponseError(String),
   PictrsPurgeResponseError(String),
   ImageUrlMissingPathSegments,
diff --git a/crates/utils/tests/test_errors_used.rs b/crates/utils/tests/test_errors_used.rs
index 5324ee45a..562d399dc 100644
--- a/crates/utils/tests/test_errors_used.rs
+++ b/crates/utils/tests/test_errors_used.rs
@@ -9,20 +9,34 @@ fn test_errors_used() {
   current_dir.pop();
   current_dir.pop();
   for error in LemmyErrorType::iter() {
-    let mut command = Command::new("grep");
-    let command = command
+    let mut grep_all = Command::new("grep");
+    let grep_all = grep_all
       .current_dir(current_dir.clone())
       .arg("-R")
       .arg("--exclude=error.rs")
       .arg(error.to_string())
       .arg("crates/")
       .arg("src/");
-    let output = command.output().unwrap();
-    let stdout = std::str::from_utf8(&output.stdout).unwrap();
-    if stdout.len() == 0 {
+    let output = grep_all.output().unwrap();
+    let grep_all_out = std::str::from_utf8(&output.stdout).unwrap();
+
+    let mut grep_apub = Command::new("grep");
+    let grep_apub = grep_apub
+      .current_dir(current_dir.clone())
+      .arg("-R")
+      .arg(error.to_string())
+      .arg("crates/apub/");
+    let output = grep_apub.output().unwrap();
+    let grep_apub_out = std::str::from_utf8(&output.stdout).unwrap();
+
+    if grep_all_out.len() == 0 {
       println!("LemmyErrorType::{} is unused", error);
       unused_error_found = true;
     }
+    if grep_all_out == grep_apub_out {
+      println!("LemmyErrorType::{} is only used for federation", error);
+      unused_error_found = true;
+    }
   }
   assert!(unused_error_found == false);
 }