From bc523abd629071cc411ffa24cfac690b06ff0a4a Mon Sep 17 00:00:00 2001 From: Dessalines Date: Tue, 11 Aug 2020 10:58:32 -0400 Subject: [PATCH] Add a simple linked instances page. Fixes #1070 (#1071) * Add a simple linked instances page. Fixes #1070 * Changing allowed_instances to federated_instances. --- server/lemmy_utils/src/settings.rs | 14 ++++ server/src/api/site.rs | 3 + server/src/apub/mod.rs | 8 +-- server/src/routes/index.rs | 3 +- ui/src/components/admin-settings.tsx | 1 + ui/src/components/footer.tsx | 5 ++ ui/src/components/instances.tsx | 98 ++++++++++++++++++++++++++++ ui/src/components/main.tsx | 1 + ui/src/components/navbar.tsx | 1 + ui/src/components/post.tsx | 1 + ui/src/components/user.tsx | 1 + ui/src/index.tsx | 2 + ui/src/interfaces.ts | 1 + ui/translations/en.json | 5 +- 14 files changed, 136 insertions(+), 8 deletions(-) create mode 100644 ui/src/components/instances.tsx diff --git a/server/lemmy_utils/src/settings.rs b/server/lemmy_utils/src/settings.rs index 6a566de7..55b6cbb3 100644 --- a/server/lemmy_utils/src/settings.rs +++ b/server/lemmy_utils/src/settings.rs @@ -133,6 +133,20 @@ impl Settings { fs::read_to_string(CONFIG_FILE) } + pub fn get_allowed_instances(&self) -> Vec { + let mut allowed_instances: Vec = self + .federation + .allowed_instances + .split(',') + .map(|d| d.to_string()) + .collect(); + + // The defaults.hjson config always returns a [""] + allowed_instances.retain(|d| !d.eq("")); + + allowed_instances + } + pub fn save_config_file(data: &str) -> Result { fs::write(CONFIG_FILE, data)?; diff --git a/server/src/api/site.rs b/server/src/api/site.rs index dcbd6216..515c3e5b 100644 --- a/server/src/api/site.rs +++ b/server/src/api/site.rs @@ -130,6 +130,7 @@ pub struct GetSiteResponse { pub online: usize, version: String, my_user: Option, + federated_instances: Vec, } #[derive(Serialize, Deserialize)] @@ -433,6 +434,7 @@ impl Perform for Oper { online, version: version::VERSION.to_string(), my_user, + federated_instances: Settings::get().get_allowed_instances(), }) } } @@ -659,6 +661,7 @@ impl Perform for Oper { online: 0, version: version::VERSION.to_string(), my_user: Some(user), + federated_instances: Settings::get().get_allowed_instances(), }) } } diff --git a/server/src/apub/mod.rs b/server/src/apub/mod.rs index f6747198..49176268 100644 --- a/server/src/apub/mod.rs +++ b/server/src/apub/mod.rs @@ -76,12 +76,8 @@ fn check_is_apub_id_valid(apub_id: &Url) -> Result<(), LemmyError> { return Err(anyhow!("invalid apub id scheme: {:?}", apub_id.scheme()).into()); } - let mut allowed_instances: Vec = Settings::get() - .federation - .allowed_instances - .split(',') - .map(|d| d.to_string()) - .collect(); + let mut allowed_instances: Vec = Settings::get().get_allowed_instances(); + // need to allow this explicitly because apub activities might contain objects from our local // instance. replace is needed to remove the port in our federation test setup. let settings = Settings::get(); diff --git a/server/src/routes/index.rs b/server/src/routes/index.rs index b579a195..88a36c39 100644 --- a/server/src/routes/index.rs +++ b/server/src/routes/index.rs @@ -40,7 +40,8 @@ pub fn config(cfg: &mut web::ServiceConfig) { ) .route("/search", web::get().to(index)) .route("/sponsors", web::get().to(index)) - .route("/password_change/{token}", web::get().to(index)); + .route("/password_change/{token}", web::get().to(index)) + .route("/instances", web::get().to(index)); } async fn index() -> Result { diff --git a/ui/src/components/admin-settings.tsx b/ui/src/components/admin-settings.tsx index 8157d4a3..fe50b1e9 100644 --- a/ui/src/components/admin-settings.tsx +++ b/ui/src/components/admin-settings.tsx @@ -48,6 +48,7 @@ export class AdminSettings extends Component { banned: [], online: null, version: null, + federated_instances: null, }, siteConfigForm: { config_hjson: null, diff --git a/ui/src/components/footer.tsx b/ui/src/components/footer.tsx index e911370f..6e7acb7a 100644 --- a/ui/src/components/footer.tsx +++ b/ui/src/components/footer.tsx @@ -51,6 +51,11 @@ export class Footer extends Component { {i18n.t('modlog')} +
  • + + {i18n.t('instances')} + +
  • {i18n.t('docs')} diff --git a/ui/src/components/instances.tsx b/ui/src/components/instances.tsx new file mode 100644 index 00000000..ae4e3f13 --- /dev/null +++ b/ui/src/components/instances.tsx @@ -0,0 +1,98 @@ +import { Component } from 'inferno'; +import { Helmet } from 'inferno-helmet'; +import { Subscription } from 'rxjs'; +import { retryWhen, delay, take } from 'rxjs/operators'; +import { + UserOperation, + WebSocketJsonResponse, + GetSiteResponse, +} from '../interfaces'; +import { WebSocketService } from '../services'; +import { wsJsonToRes, toast } from '../utils'; +import { i18n } from '../i18next'; + +interface InstancesState { + loading: boolean; + siteRes: GetSiteResponse; +} + +export class Instances extends Component { + private subscription: Subscription; + private emptyState: InstancesState = { + loading: true, + siteRes: undefined, + }; + + constructor(props: any, context: any) { + super(props, context); + this.state = this.emptyState; + this.subscription = WebSocketService.Instance.subject + .pipe(retryWhen(errors => errors.pipe(delay(3000), take(10)))) + .subscribe( + msg => this.parseMessage(msg), + err => console.error(err), + () => console.log('complete') + ); + + WebSocketService.Instance.getSite(); + } + + componentWillUnmount() { + this.subscription.unsubscribe(); + } + + get documentTitle(): string { + if (this.state.siteRes) { + return `${i18n.t('instances')} - ${this.state.siteRes.site.name}`; + } else { + return 'Lemmy'; + } + } + + render() { + return ( +
    + + {this.state.loading ? ( +
    + +
    + ) : ( +     + )} +
    + ); + } + + parseMessage(msg: WebSocketJsonResponse) { + console.log(msg); + let res = wsJsonToRes(msg); + if (msg.error) { + toast(i18n.t(msg.error), 'danger'); + return; + } else if (res.op == UserOperation.GetSite) { + let data = res.data as GetSiteResponse; + this.state.siteRes = data; + this.state.loading = false; + this.setState(this.state); + } + } +} diff --git a/ui/src/components/main.tsx b/ui/src/components/main.tsx index 9fbd1ae2..246db674 100644 --- a/ui/src/components/main.tsx +++ b/ui/src/components/main.tsx @@ -114,6 +114,7 @@ export class Main extends Component { banned: [], online: null, version: null, + federated_instances: null, }, showEditSite: false, loading: true, diff --git a/ui/src/components/navbar.tsx b/ui/src/components/navbar.tsx index 676ab8d4..351d00b8 100644 --- a/ui/src/components/navbar.tsx +++ b/ui/src/components/navbar.tsx @@ -82,6 +82,7 @@ export class Navbar extends Component { banned: [], online: null, version: null, + federated_instances: null, }, searchParam: '', toggleSearch: false, diff --git a/ui/src/components/post.tsx b/ui/src/components/post.tsx index 3778ec90..06f461f3 100644 --- a/ui/src/components/post.tsx +++ b/ui/src/components/post.tsx @@ -97,6 +97,7 @@ export class Post extends Component { }, online: null, version: null, + federated_instances: undefined, }, }; diff --git a/ui/src/components/user.tsx b/ui/src/components/user.tsx index e14f56a1..d7db0ae2 100644 --- a/ui/src/components/user.tsx +++ b/ui/src/components/user.tsx @@ -142,6 +142,7 @@ export class User extends Component { }, version: undefined, my_user: undefined, + federated_instances: undefined, }, }; diff --git a/ui/src/index.tsx b/ui/src/index.tsx index 8e49df9f..aa373de4 100644 --- a/ui/src/index.tsx +++ b/ui/src/index.tsx @@ -19,6 +19,7 @@ import { AdminSettings } from './components/admin-settings'; import { Inbox } from './components/inbox'; import { Search } from './components/search'; import { Sponsors } from './components/sponsors'; +import { Instances } from './components/instances'; import { Symbols } from './components/symbols'; import { i18n } from './i18next'; @@ -89,6 +90,7 @@ class Index extends Component { path={`/password_change/:token`} component={PasswordChange} /> + diff --git a/ui/src/interfaces.ts b/ui/src/interfaces.ts index 1e8899b9..b449060d 100644 --- a/ui/src/interfaces.ts +++ b/ui/src/interfaces.ts @@ -867,6 +867,7 @@ export interface GetSiteResponse { online: number; version: string; my_user?: User; + federated_instances: Array; } export interface SiteResponse { diff --git a/ui/translations/en.json b/ui/translations/en.json index a537252e..e3ccf8d9 100644 --- a/ui/translations/en.json +++ b/ui/translations/en.json @@ -294,5 +294,8 @@ "invalid_post_title": "Invalid post title", "invalid_url": "Invalid URL.", "play_captcha_audio": "Play Captcha Audio", - "bio": "Bio" + "bio": "Bio", + "instances": "Instances", + "linked_instances": "Linked Instances", + "none_found": "None found." }