LemmyNet/lemmy
2
0
Fork 0
mirror of https://github.com/LemmyNet/lemmy.git synced 2024-12-23 03:11:32 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Only check auth secure on release mode. (#4127)

Browse source 
* Only check auth secure on release mode.

* Fixing wrong js-client.

* Adding is_debug_mode var.
This commit is contained in:
Dessalines 2023-11-07 05:03:13 -05:00 committed by GitHub
parent cb01427dcf
commit 98ed0e51cc
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
crates/api/src/lib.rs
View file

@ -85,7 +85,9 @@ pub fn read_auth_token(req: &HttpRequest) -> Result<Option<String>, LemmyError>
// ensure that its marked as httponly and secure
let secure = cookie.secure().unwrap_or_default();
let http_only = cookie.http_only().unwrap_or_default();
if !secure || !http_only {
let is_debug_mode = cfg!(debug_assertions);
if !is_debug_mode && (!secure || !http_only) {
Err(LemmyError::from(LemmyErrorType::AuthCookieInsecure))
} else {
Ok(Some(cookie.value().to_string()))

2
crates/apub/src/activities/voting/mod.rs
View file

@ -33,7 +33,7 @@ pub(crate) async fn send_like_activity(
score: i16,
context: Data<LemmyContext>,
) -> Result<(), LemmyError> {
let object_id: ObjectId<PostOrComment> = object_id.try_into()?;
let object_id: ObjectId<PostOrComment> = object_id.into();
let actor: ApubPerson = actor.into();
let community: ApubCommunity = community.into();