Removing local_user.show_scores column, since its now on the (#4497)

local_user_vote_display_mode table.

- See https://github.com/LemmyNet/lemmy/pull/4450

crates/api/src/local_user/save_settings.rs

@@ -135,7 +135,6 @@ pub async fn save_user_settings(
     blur_nsfw: data.blur_nsfw,
     auto_expand: data.auto_expand,
     show_bot_accounts: data.show_bot_accounts,
-    show_scores: data.show_scores,
     default_sort_type,
     default_listing_type,
     theme: data.theme.clone(),

crates/apub/src/api/user_settings_backup.rs

@@ -122,7 +122,6 @@ pub async fn import_settings(
       .settings
       .as_ref()
       .map(|s| s.send_notifications_to_email),
-    show_scores: data.settings.as_ref().map(|s| s.show_scores),
     show_bot_accounts: data.settings.as_ref().map(|s| s.show_bot_accounts),
     show_read_posts: data.settings.as_ref().map(|s| s.show_read_posts),
     open_links_in_new_tab: data.settings.as_ref().map(|s| s.open_links_in_new_tab),

crates/db_schema/src/schema.rs

@@ -446,7 +446,6 @@ diesel::table! {
         interface_language -> Varchar,
         show_avatars -> Bool,
         send_notifications_to_email -> Bool,
-        show_scores -> Bool,
         show_bot_accounts -> Bool,
         show_read_posts -> Bool,
         email_verified -> Bool,

crates/db_schema/src/source/local_user.rs

@@ -35,9 +35,6 @@ pub struct LocalUser {
   /// Whether to show avatars.
   pub show_avatars: bool,
   pub send_notifications_to_email: bool,
-  /// Whether to show comment / post scores.
-  // TODO now that there is a vote_display_mode, this can be gotten rid of in future releases.
-  pub show_scores: bool,
   /// Whether to show bot accounts.
   pub show_bot_accounts: bool,
   /// Whether to show read posts.
@@ -93,8 +90,6 @@ pub struct LocalUserInsertForm {
   #[new(default)]
   pub show_bot_accounts: Option<bool>,
   #[new(default)]
-  pub show_scores: Option<bool>,
-  #[new(default)]
   pub show_read_posts: Option<bool>,
   #[new(default)]
   pub email_verified: Option<bool>,
@@ -138,7 +133,6 @@ pub struct LocalUserUpdateForm {
   pub show_avatars: Option<bool>,
   pub send_notifications_to_email: Option<bool>,
   pub show_bot_accounts: Option<bool>,
-  pub show_scores: Option<bool>,
   pub show_read_posts: Option<bool>,
   pub email_verified: Option<bool>,
   pub accepted_application: Option<bool>,

crates/db_views/src/registration_application_view.rs

@@ -252,7 +252,6 @@ mod tests {
         show_avatars: inserted_sara_local_user.show_avatars,
         send_notifications_to_email: inserted_sara_local_user.send_notifications_to_email,
         show_bot_accounts: inserted_sara_local_user.show_bot_accounts,
-        show_scores: inserted_sara_local_user.show_scores,
         show_read_posts: inserted_sara_local_user.show_read_posts,
         email_verified: inserted_sara_local_user.email_verified,
         accepted_application: inserted_sara_local_user.accepted_application,

migrations/2024-03-04-143245_remove_show_scores_column/down.sql

@@ -0,0 +1,3 @@
+ALTER TABLE local_user
+    ADD COLUMN show_scores boolean NOT NULL DEFAULT TRUE;
+

migrations/2024-03-04-143245_remove_show_scores_column/up.sql

@@ -0,0 +1,3 @@
+ALTER TABLE local_user
+    DROP COLUMN show_scores;
+