Consider remote instance as dead if it returns any status 4xx or 5xx (#5256)

* Consider remote instance as dead if it returns any status 4xx or 5xx (ref #3134)

* remove dbg
This commit is contained in:
Nutomic 2024-12-12 14:38:16 +00:00 committed by GitHub
parent 8a5daeec97
commit 2467a0af12
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -579,13 +579,13 @@ async fn build_update_instance_form(
// This is the only kind of error that means the instance is dead // This is the only kind of error that means the instance is dead
return None; return None;
}; };
let status = res.status();
// In this block, returning `None` is ignored, and only means not writing nodeinfo to db if status.is_client_error() || status.is_server_error() {
async {
if res.status().is_client_error() {
return None; return None;
} }
// In this block, returning `None` is ignored, and only means not writing nodeinfo to db
async {
let node_info_url = res let node_info_url = res
.json::<NodeInfoWellKnown>() .json::<NodeInfoWellKnown>()
.await .await