2021-07-17 16:20:44 +00:00
|
|
|
use crate::{
|
|
|
|
activities::{
|
2021-10-14 16:33:19 +00:00
|
|
|
check_community_deleted_or_removed,
|
2021-08-17 18:04:58 +00:00
|
|
|
comment::{collect_non_local_mentions, get_notif_recipients},
|
2021-10-29 10:32:42 +00:00
|
|
|
community::{announce::GetCommunity, send_to_community},
|
2021-07-31 14:57:37 +00:00
|
|
|
generate_activity_id,
|
2021-07-17 16:20:44 +00:00
|
|
|
verify_activity,
|
2021-10-25 17:22:34 +00:00
|
|
|
verify_is_public,
|
2021-07-17 16:20:44 +00:00
|
|
|
verify_person_in_community,
|
|
|
|
},
|
2021-10-29 10:32:42 +00:00
|
|
|
activity_lists::AnnouncableActivities,
|
2021-10-28 21:17:59 +00:00
|
|
|
objects::{comment::ApubComment, community::ApubCommunity, person::ApubPerson},
|
2021-10-29 10:32:42 +00:00
|
|
|
protocol::activities::{create_or_update::comment::CreateOrUpdateComment, CreateOrUpdateType},
|
Apub inbox rewrite (#1652)
* start to implement apub inbox routing lib
* got something that almost works
* it compiles!
* implemented some more
* move library code to separate crate (most of it)
* convert private message handlers
* convert all comment receivers (except undo comment)
* convert post receiver
* add verify trait
* convert community receivers
* add cc field for all activities which i forgot before
* convert inbox functions, add missing checks
* convert undo like/dislike receivers
* convert undo_delete and undo_remove receivers
* move block/unblock activities
* convert remaining activity receivers
* reimplement http signature verification and other checks
* also use actor type for routing, VerifyActivity and SendActivity traits
* cleanup and restructure apub_receive code
* wip: try to fix activity routing
* implement a (very bad) derive macro for activityhandler
* working activity routing!
* rework pm verify(), fix tests and confirm manually
also remove inbox username check which was broken
* rework following verify(), fix tests and test manually
* fix post/comment create/update, rework voting
* Rewrite remove/delete post/comment, fix tests, test manually
* Rework and fix (un)block user, announce, update post
* some code cleanup
* rework delete/remove activity receivers (still quite messy)
* rewrite, test and fix add/remove mod, update community handlers
* add docs for ActivityHandler derive macro
* dont try to compile macro comments
2021-07-17 16:08:46 +00:00
|
|
|
};
|
2021-11-03 17:33:51 +00:00
|
|
|
use activitystreams::public;
|
|
|
|
use lemmy_api_common::{blocking, check_post_deleted_or_removed};
|
|
|
|
use lemmy_apub_lib::{
|
|
|
|
data::Data,
|
2021-11-05 00:24:10 +00:00
|
|
|
object_id::ObjectId,
|
2021-11-03 17:33:51 +00:00
|
|
|
traits::{ActivityHandler, ActorType, ApubObject},
|
|
|
|
verify::verify_domains_match,
|
|
|
|
};
|
|
|
|
use lemmy_db_schema::{
|
|
|
|
source::{community::Community, post::Post},
|
|
|
|
traits::Crud,
|
|
|
|
};
|
|
|
|
use lemmy_utils::LemmyError;
|
|
|
|
use lemmy_websocket::{send::send_comment_ws_message, LemmyContext, UserOperationCrud};
|
Apub inbox rewrite (#1652)
* start to implement apub inbox routing lib
* got something that almost works
* it compiles!
* implemented some more
* move library code to separate crate (most of it)
* convert private message handlers
* convert all comment receivers (except undo comment)
* convert post receiver
* add verify trait
* convert community receivers
* add cc field for all activities which i forgot before
* convert inbox functions, add missing checks
* convert undo like/dislike receivers
* convert undo_delete and undo_remove receivers
* move block/unblock activities
* convert remaining activity receivers
* reimplement http signature verification and other checks
* also use actor type for routing, VerifyActivity and SendActivity traits
* cleanup and restructure apub_receive code
* wip: try to fix activity routing
* implement a (very bad) derive macro for activityhandler
* working activity routing!
* rework pm verify(), fix tests and confirm manually
also remove inbox username check which was broken
* rework following verify(), fix tests and test manually
* fix post/comment create/update, rework voting
* Rewrite remove/delete post/comment, fix tests, test manually
* Rework and fix (un)block user, announce, update post
* some code cleanup
* rework delete/remove activity receivers (still quite messy)
* rewrite, test and fix add/remove mod, update community handlers
* add docs for ActivityHandler derive macro
* dont try to compile macro comments
2021-07-17 16:08:46 +00:00
|
|
|
|
2021-07-31 15:09:43 +00:00
|
|
|
impl CreateOrUpdateComment {
|
2021-07-31 14:57:37 +00:00
|
|
|
pub async fn send(
|
2021-11-06 12:37:55 +00:00
|
|
|
comment: ApubComment,
|
2021-10-18 21:36:44 +00:00
|
|
|
actor: &ApubPerson,
|
2021-07-31 15:09:43 +00:00
|
|
|
kind: CreateOrUpdateType,
|
2021-07-31 14:57:37 +00:00
|
|
|
context: &LemmyContext,
|
|
|
|
) -> Result<(), LemmyError> {
|
2021-07-31 15:09:43 +00:00
|
|
|
// TODO: might be helpful to add a comment method to retrieve community directly
|
2021-07-31 14:57:37 +00:00
|
|
|
let post_id = comment.post_id;
|
|
|
|
let post = blocking(context.pool(), move |conn| Post::read(conn, post_id)).await??;
|
|
|
|
let community_id = post.community_id;
|
2021-10-18 21:36:44 +00:00
|
|
|
let community: ApubCommunity = blocking(context.pool(), move |conn| {
|
2021-07-31 14:57:37 +00:00
|
|
|
Community::read(conn, community_id)
|
|
|
|
})
|
2021-10-18 21:36:44 +00:00
|
|
|
.await??
|
|
|
|
.into();
|
2021-07-31 15:09:43 +00:00
|
|
|
|
2021-09-22 15:57:09 +00:00
|
|
|
let id = generate_activity_id(
|
|
|
|
kind.clone(),
|
|
|
|
&context.settings().get_protocol_and_hostname(),
|
|
|
|
)?;
|
2021-11-06 12:37:55 +00:00
|
|
|
let maa = collect_non_local_mentions(&comment, &community, context).await?;
|
2021-07-31 14:57:37 +00:00
|
|
|
|
2021-07-31 15:09:43 +00:00
|
|
|
let create_or_update = CreateOrUpdateComment {
|
2021-09-25 15:44:52 +00:00
|
|
|
actor: ObjectId::new(actor.actor_id()),
|
2021-10-25 17:22:34 +00:00
|
|
|
to: vec![public()],
|
2021-11-06 12:37:55 +00:00
|
|
|
object: comment.into_apub(context).await?,
|
2021-07-31 14:57:37 +00:00
|
|
|
cc: maa.ccs,
|
|
|
|
tag: maa.tags,
|
2021-07-31 15:09:43 +00:00
|
|
|
kind,
|
2021-08-19 21:24:33 +00:00
|
|
|
id: id.clone(),
|
|
|
|
unparsed: Default::default(),
|
2021-07-31 14:57:37 +00:00
|
|
|
};
|
|
|
|
|
2021-07-31 15:09:43 +00:00
|
|
|
let activity = AnnouncableActivities::CreateOrUpdateComment(create_or_update);
|
2021-10-06 20:20:05 +00:00
|
|
|
send_to_community(activity, &id, actor, &community, maa.inboxes, context).await
|
2021-07-31 14:57:37 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
Apub inbox rewrite (#1652)
* start to implement apub inbox routing lib
* got something that almost works
* it compiles!
* implemented some more
* move library code to separate crate (most of it)
* convert private message handlers
* convert all comment receivers (except undo comment)
* convert post receiver
* add verify trait
* convert community receivers
* add cc field for all activities which i forgot before
* convert inbox functions, add missing checks
* convert undo like/dislike receivers
* convert undo_delete and undo_remove receivers
* move block/unblock activities
* convert remaining activity receivers
* reimplement http signature verification and other checks
* also use actor type for routing, VerifyActivity and SendActivity traits
* cleanup and restructure apub_receive code
* wip: try to fix activity routing
* implement a (very bad) derive macro for activityhandler
* working activity routing!
* rework pm verify(), fix tests and confirm manually
also remove inbox username check which was broken
* rework following verify(), fix tests and test manually
* fix post/comment create/update, rework voting
* Rewrite remove/delete post/comment, fix tests, test manually
* Rework and fix (un)block user, announce, update post
* some code cleanup
* rework delete/remove activity receivers (still quite messy)
* rewrite, test and fix add/remove mod, update community handlers
* add docs for ActivityHandler derive macro
* dont try to compile macro comments
2021-07-17 16:08:46 +00:00
|
|
|
#[async_trait::async_trait(?Send)]
|
2021-07-31 15:09:43 +00:00
|
|
|
impl ActivityHandler for CreateOrUpdateComment {
|
2021-10-06 20:20:05 +00:00
|
|
|
type DataType = LemmyContext;
|
|
|
|
|
Apub inbox rewrite (#1652)
* start to implement apub inbox routing lib
* got something that almost works
* it compiles!
* implemented some more
* move library code to separate crate (most of it)
* convert private message handlers
* convert all comment receivers (except undo comment)
* convert post receiver
* add verify trait
* convert community receivers
* add cc field for all activities which i forgot before
* convert inbox functions, add missing checks
* convert undo like/dislike receivers
* convert undo_delete and undo_remove receivers
* move block/unblock activities
* convert remaining activity receivers
* reimplement http signature verification and other checks
* also use actor type for routing, VerifyActivity and SendActivity traits
* cleanup and restructure apub_receive code
* wip: try to fix activity routing
* implement a (very bad) derive macro for activityhandler
* working activity routing!
* rework pm verify(), fix tests and confirm manually
also remove inbox username check which was broken
* rework following verify(), fix tests and test manually
* fix post/comment create/update, rework voting
* Rewrite remove/delete post/comment, fix tests, test manually
* Rework and fix (un)block user, announce, update post
* some code cleanup
* rework delete/remove activity receivers (still quite messy)
* rewrite, test and fix add/remove mod, update community handlers
* add docs for ActivityHandler derive macro
* dont try to compile macro comments
2021-07-17 16:08:46 +00:00
|
|
|
async fn verify(
|
|
|
|
&self,
|
2021-10-06 20:20:05 +00:00
|
|
|
context: &Data<LemmyContext>,
|
Apub inbox rewrite (#1652)
* start to implement apub inbox routing lib
* got something that almost works
* it compiles!
* implemented some more
* move library code to separate crate (most of it)
* convert private message handlers
* convert all comment receivers (except undo comment)
* convert post receiver
* add verify trait
* convert community receivers
* add cc field for all activities which i forgot before
* convert inbox functions, add missing checks
* convert undo like/dislike receivers
* convert undo_delete and undo_remove receivers
* move block/unblock activities
* convert remaining activity receivers
* reimplement http signature verification and other checks
* also use actor type for routing, VerifyActivity and SendActivity traits
* cleanup and restructure apub_receive code
* wip: try to fix activity routing
* implement a (very bad) derive macro for activityhandler
* working activity routing!
* rework pm verify(), fix tests and confirm manually
also remove inbox username check which was broken
* rework following verify(), fix tests and test manually
* fix post/comment create/update, rework voting
* Rewrite remove/delete post/comment, fix tests, test manually
* Rework and fix (un)block user, announce, update post
* some code cleanup
* rework delete/remove activity receivers (still quite messy)
* rewrite, test and fix add/remove mod, update community handlers
* add docs for ActivityHandler derive macro
* dont try to compile macro comments
2021-07-17 16:08:46 +00:00
|
|
|
request_counter: &mut i32,
|
|
|
|
) -> Result<(), LemmyError> {
|
2021-10-25 17:22:34 +00:00
|
|
|
verify_is_public(&self.to)?;
|
2021-10-14 16:33:19 +00:00
|
|
|
let post = self.object.get_parents(context, request_counter).await?.0;
|
2021-10-28 11:46:48 +00:00
|
|
|
let community = self.get_community(context, request_counter).await?;
|
2021-07-27 22:18:50 +00:00
|
|
|
|
2021-11-03 17:33:51 +00:00
|
|
|
verify_activity(&self.id, self.actor.inner(), &context.settings())?;
|
2021-10-28 11:46:48 +00:00
|
|
|
verify_person_in_community(&self.actor, &community, context, request_counter).await?;
|
2021-11-03 16:26:09 +00:00
|
|
|
verify_domains_match(self.actor.inner(), self.object.id.inner())?;
|
2021-10-14 16:33:19 +00:00
|
|
|
check_community_deleted_or_removed(&community)?;
|
|
|
|
check_post_deleted_or_removed(&post)?;
|
|
|
|
|
Apub inbox rewrite (#1652)
* start to implement apub inbox routing lib
* got something that almost works
* it compiles!
* implemented some more
* move library code to separate crate (most of it)
* convert private message handlers
* convert all comment receivers (except undo comment)
* convert post receiver
* add verify trait
* convert community receivers
* add cc field for all activities which i forgot before
* convert inbox functions, add missing checks
* convert undo like/dislike receivers
* convert undo_delete and undo_remove receivers
* move block/unblock activities
* convert remaining activity receivers
* reimplement http signature verification and other checks
* also use actor type for routing, VerifyActivity and SendActivity traits
* cleanup and restructure apub_receive code
* wip: try to fix activity routing
* implement a (very bad) derive macro for activityhandler
* working activity routing!
* rework pm verify(), fix tests and confirm manually
also remove inbox username check which was broken
* rework following verify(), fix tests and test manually
* fix post/comment create/update, rework voting
* Rewrite remove/delete post/comment, fix tests, test manually
* Rework and fix (un)block user, announce, update post
* some code cleanup
* rework delete/remove activity receivers (still quite messy)
* rewrite, test and fix add/remove mod, update community handlers
* add docs for ActivityHandler derive macro
* dont try to compile macro comments
2021-07-17 16:08:46 +00:00
|
|
|
// TODO: should add a check that the correct community is in cc (probably needs changes to
|
|
|
|
// comment deserialization)
|
2021-07-31 14:57:37 +00:00
|
|
|
self.object.verify(context, request_counter).await?;
|
Apub inbox rewrite (#1652)
* start to implement apub inbox routing lib
* got something that almost works
* it compiles!
* implemented some more
* move library code to separate crate (most of it)
* convert private message handlers
* convert all comment receivers (except undo comment)
* convert post receiver
* add verify trait
* convert community receivers
* add cc field for all activities which i forgot before
* convert inbox functions, add missing checks
* convert undo like/dislike receivers
* convert undo_delete and undo_remove receivers
* move block/unblock activities
* convert remaining activity receivers
* reimplement http signature verification and other checks
* also use actor type for routing, VerifyActivity and SendActivity traits
* cleanup and restructure apub_receive code
* wip: try to fix activity routing
* implement a (very bad) derive macro for activityhandler
* working activity routing!
* rework pm verify(), fix tests and confirm manually
also remove inbox username check which was broken
* rework following verify(), fix tests and test manually
* fix post/comment create/update, rework voting
* Rewrite remove/delete post/comment, fix tests, test manually
* Rework and fix (un)block user, announce, update post
* some code cleanup
* rework delete/remove activity receivers (still quite messy)
* rewrite, test and fix add/remove mod, update community handlers
* add docs for ActivityHandler derive macro
* dont try to compile macro comments
2021-07-17 16:08:46 +00:00
|
|
|
Ok(())
|
|
|
|
}
|
|
|
|
|
|
|
|
async fn receive(
|
2021-08-12 12:48:09 +00:00
|
|
|
self,
|
2021-10-06 20:20:05 +00:00
|
|
|
context: &Data<LemmyContext>,
|
Apub inbox rewrite (#1652)
* start to implement apub inbox routing lib
* got something that almost works
* it compiles!
* implemented some more
* move library code to separate crate (most of it)
* convert private message handlers
* convert all comment receivers (except undo comment)
* convert post receiver
* add verify trait
* convert community receivers
* add cc field for all activities which i forgot before
* convert inbox functions, add missing checks
* convert undo like/dislike receivers
* convert undo_delete and undo_remove receivers
* move block/unblock activities
* convert remaining activity receivers
* reimplement http signature verification and other checks
* also use actor type for routing, VerifyActivity and SendActivity traits
* cleanup and restructure apub_receive code
* wip: try to fix activity routing
* implement a (very bad) derive macro for activityhandler
* working activity routing!
* rework pm verify(), fix tests and confirm manually
also remove inbox username check which was broken
* rework following verify(), fix tests and test manually
* fix post/comment create/update, rework voting
* Rewrite remove/delete post/comment, fix tests, test manually
* Rework and fix (un)block user, announce, update post
* some code cleanup
* rework delete/remove activity receivers (still quite messy)
* rewrite, test and fix add/remove mod, update community handlers
* add docs for ActivityHandler derive macro
* dont try to compile macro comments
2021-07-17 16:08:46 +00:00
|
|
|
request_counter: &mut i32,
|
|
|
|
) -> Result<(), LemmyError> {
|
2021-09-25 15:44:52 +00:00
|
|
|
let comment =
|
2021-11-06 12:37:55 +00:00
|
|
|
ApubComment::from_apub(self.object, context, self.actor.inner(), request_counter).await?;
|
2021-08-19 21:24:33 +00:00
|
|
|
let recipients = get_notif_recipients(&self.actor, &comment, context, request_counter).await?;
|
2021-07-31 15:09:43 +00:00
|
|
|
let notif_type = match self.kind {
|
|
|
|
CreateOrUpdateType::Create => UserOperationCrud::CreateComment,
|
|
|
|
CreateOrUpdateType::Update => UserOperationCrud::EditComment,
|
|
|
|
};
|
2021-08-17 18:04:58 +00:00
|
|
|
send_comment_ws_message(
|
|
|
|
comment.id, notif_type, None, None, None, recipients, context,
|
|
|
|
)
|
|
|
|
.await?;
|
|
|
|
Ok(())
|
Apub inbox rewrite (#1652)
* start to implement apub inbox routing lib
* got something that almost works
* it compiles!
* implemented some more
* move library code to separate crate (most of it)
* convert private message handlers
* convert all comment receivers (except undo comment)
* convert post receiver
* add verify trait
* convert community receivers
* add cc field for all activities which i forgot before
* convert inbox functions, add missing checks
* convert undo like/dislike receivers
* convert undo_delete and undo_remove receivers
* move block/unblock activities
* convert remaining activity receivers
* reimplement http signature verification and other checks
* also use actor type for routing, VerifyActivity and SendActivity traits
* cleanup and restructure apub_receive code
* wip: try to fix activity routing
* implement a (very bad) derive macro for activityhandler
* working activity routing!
* rework pm verify(), fix tests and confirm manually
also remove inbox username check which was broken
* rework following verify(), fix tests and test manually
* fix post/comment create/update, rework voting
* Rewrite remove/delete post/comment, fix tests, test manually
* Rework and fix (un)block user, announce, update post
* some code cleanup
* rework delete/remove activity receivers (still quite messy)
* rewrite, test and fix add/remove mod, update community handlers
* add docs for ActivityHandler derive macro
* dont try to compile macro comments
2021-07-17 16:08:46 +00:00
|
|
|
}
|
|
|
|
}
|
2021-10-26 10:47:26 +00:00
|
|
|
|
2021-10-28 11:46:48 +00:00
|
|
|
#[async_trait::async_trait(?Send)]
|
|
|
|
impl GetCommunity for CreateOrUpdateComment {
|
|
|
|
async fn get_community(
|
|
|
|
&self,
|
|
|
|
context: &LemmyContext,
|
|
|
|
request_counter: &mut i32,
|
|
|
|
) -> Result<ApubCommunity, LemmyError> {
|
|
|
|
let post = self.object.get_parents(context, request_counter).await?.0;
|
|
|
|
let community = blocking(context.pool(), move |conn| {
|
|
|
|
Community::read(conn, post.community_id)
|
|
|
|
})
|
|
|
|
.await??;
|
|
|
|
Ok(community.into())
|
|
|
|
}
|
|
|
|
}
|