From a2bcc37008b78cef14f00841a54337135fc77ccb Mon Sep 17 00:00:00 2001
From: SleeplessOne1917 <abias1122@gmail.com>
Date: Wed, 3 May 2023 16:09:47 +0000
Subject: [PATCH] Handle when logged out (#986)

* Add logged out messages to profile and community

* Remove errors when not logged in

* Add logged out translations
---
 lemmy-translations                            |  2 +-
 .../components/community/create-community.tsx |  9 +++------
 src/shared/components/community/sidebar.tsx   | 19 +++++++++++++++----
 src/shared/components/person/profile.tsx      |  5 +++++
 src/shared/components/post/create-post.tsx    | 18 ++++++++++++------
 5 files changed, 36 insertions(+), 17 deletions(-)

diff --git a/lemmy-translations b/lemmy-translations
index 73797162..3ad48e2c 160000
--- a/lemmy-translations
+++ b/lemmy-translations
@@ -1 +1 @@
-Subproject commit 7379716231b9f7e67f710751c839398b7ab5d65e
+Subproject commit 3ad48e2c3cb444c76399aa31d50a13f7571e4aab
diff --git a/src/shared/components/community/create-community.tsx b/src/shared/components/community/create-community.tsx
index da8ef09d..81c62531 100644
--- a/src/shared/components/community/create-community.tsx
+++ b/src/shared/components/community/create-community.tsx
@@ -1,8 +1,9 @@
 import { Component } from "inferno";
+import { Redirect } from "inferno-router";
 import { CommunityView, GetSiteResponse } from "lemmy-js-client";
 import { Subscription } from "rxjs";
 import { i18n } from "../../i18next";
-import { UserService } from "../../services";
+import { UserService } from "../../services/UserService";
 import {
   enableNsfw,
   isBrowser,
@@ -32,11 +33,6 @@ export class CreateCommunity extends Component<any, CreateCommunityState> {
 
     this.parseMessage = this.parseMessage.bind(this);
     this.subscription = wsSubscribe(this.parseMessage);
-
-    if (!UserService.Instance.myUserInfo && isBrowser()) {
-      toast(i18n.t("not_logged_in"), "danger");
-      this.context.router.history.push(`/login`);
-    }
   }
 
   componentWillUnmount() {
@@ -54,6 +50,7 @@ export class CreateCommunity extends Component<any, CreateCommunityState> {
   render() {
     return (
       <div className="container-lg">
+        {!UserService.Instance.myUserInfo && <Redirect to="/login" />}
         <HtmlTags
           title={this.documentTitle}
           path={this.context.router.route.match.url}
diff --git a/src/shared/components/community/sidebar.tsx b/src/shared/components/community/sidebar.tsx
index 144075b5..9862d9ed 100644
--- a/src/shared/components/community/sidebar.tsx
+++ b/src/shared/components/community/sidebar.tsx
@@ -20,6 +20,7 @@ import {
   amMod,
   amTopMod,
   getUnixTime,
+  hostname,
   mdToHtml,
   myAuth,
   numToSI,
@@ -91,15 +92,25 @@ export class Sidebar extends Component<SidebarProps, SidebarState> {
   }
 
   sidebar() {
+    const myUSerInfo = UserService.Instance.myUserInfo;
+    const { name, actor_id } = this.props.community_view.community;
     return (
       <div>
         <div className="card border-secondary mb-3">
           <div className="card-body">
             {this.communityTitle()}
             {this.props.editable && this.adminButtons()}
-            {this.subscribe()}
+            {myUSerInfo && this.subscribe()}
             {this.canPost && this.createPost()}
-            {this.blockCommunity()}
+            {myUSerInfo && this.blockCommunity()}
+            {!myUSerInfo && (
+              <div className="alert alert-info" role="alert">
+                {i18n.t("community_not_logged_in_alert", {
+                  community: name,
+                  instance: hostname(actor_id),
+                })}
+              </div>
+            )}
           </div>
         </div>
         <div className="card border-secondary mb-3">
@@ -123,7 +134,7 @@ export class Sidebar extends Component<SidebarProps, SidebarState> {
             <BannerIconHeader icon={community.icon} banner={community.banner} />
           )}
           <span className="mr-2">{community.title}</span>
-          {subscribed == SubscribedType.Subscribed && (
+          {subscribed === SubscribedType.Subscribed && (
             <button
               className="btn btn-secondary btn-sm mr-2"
               onClick={linkEvent(this, this.handleUnsubscribe)}
@@ -132,7 +143,7 @@ export class Sidebar extends Component<SidebarProps, SidebarState> {
               {i18n.t("joined")}
             </button>
           )}
-          {subscribed == SubscribedType.Pending && (
+          {subscribed === SubscribedType.Pending && (
             <button
               className="btn btn-warning mr-2"
               onClick={linkEvent(this, this.handleUnsubscribe)}
diff --git a/src/shared/components/person/profile.tsx b/src/shared/components/person/profile.tsx
index d12a981f..bf76a4df 100644
--- a/src/shared/components/person/profile.tsx
+++ b/src/shared/components/person/profile.tsx
@@ -540,6 +540,11 @@ export class Profile extends Component<any, ProfileState> {
                     .format("MMM DD, YYYY")}
                 </span>
               </div>
+              {!UserService.Instance.myUserInfo && (
+                <div className="alert alert-info" role="alert">
+                  {i18n.t("profile_not_logged_in_alert")}
+                </div>
+              )}
             </div>
           </div>
         </div>
diff --git a/src/shared/components/post/create-post.tsx b/src/shared/components/post/create-post.tsx
index c1d282e9..b5b391e4 100644
--- a/src/shared/components/post/create-post.tsx
+++ b/src/shared/components/post/create-post.tsx
@@ -1,4 +1,5 @@
 import { Component } from "inferno";
+import { Redirect } from "inferno-router";
 import {
   GetCommunity,
   GetCommunityResponse,
@@ -53,11 +54,6 @@ export class CreatePost extends Component<any, CreatePostState> {
     this.parseMessage = this.parseMessage.bind(this);
     this.subscription = wsSubscribe(this.parseMessage);
 
-    if (!UserService.Instance.myUserInfo && isBrowser()) {
-      toast(i18n.t("not_logged_in"), "danger");
-      this.context.router.history.push(`/login`);
-    }
-
     // Only fetch the data if coming from another route
     if (this.isoData.path == this.context.router.route.match.url) {
       this.state = {
@@ -117,6 +113,7 @@ export class CreatePost extends Component<any, CreatePostState> {
     let res = this.state.listCommunitiesResponse;
     return (
       <div className="container-lg">
+        {!UserService.Instance.myUserInfo && <Redirect to="/login" />}
         <HtmlTags
           title={this.documentTitle}
           path={this.context.router.route.match.url}
@@ -166,7 +163,16 @@ export class CreatePost extends Component<any, CreatePostState> {
       url: urlParams.get("url") ?? undefined,
     };
 
-    return params;
+    const locationState = this.props.history.location.state as
+      | PostFormParams
+      | undefined;
+
+    this.props.history.replace(
+      `/create_post${getQueryString(queryParams)}`,
+      locationState
+    );
+
+    this.fetchCommunity();
   }
 
   get prevCommunityName(): string | undefined {