From 0b3d7fbde43882f833bec32d129fcfb488e7e23f Mon Sep 17 00:00:00 2001
From: Dessalines <dessalines@users.noreply.github.com>
Date: Fri, 1 Oct 2021 10:19:47 -0400
Subject: [PATCH] Add honeypot for user and form creation. Fixes #433 (#435)

---
 package.json                             |  2 +-
 src/assets/css/main.css                  |  4 ++++
 src/shared/components/home/signup.tsx    | 20 ++++++++++++++++++--
 src/shared/components/post/post-form.tsx | 15 +++++++++++++++
 yarn.lock                                |  8 ++++----
 5 files changed, 42 insertions(+), 7 deletions(-)

diff --git a/package.json b/package.json
index 65e11446..77ee390e 100644
--- a/package.json
+++ b/package.json
@@ -72,7 +72,7 @@
     "husky": "^7.0.2",
     "import-sort-style-module": "^6.0.0",
     "iso-639-1": "^2.1.9",
-    "lemmy-js-client": "0.13.0",
+    "lemmy-js-client": "0.13.1-rc.1",
     "lint-staged": "^11.0.1",
     "mini-css-extract-plugin": "^2.3.0",
     "node-fetch": "^2.6.1",
diff --git a/src/assets/css/main.css b/src/assets/css/main.css
index 2e6c7cb3..641b7bee 100644
--- a/src/assets/css/main.css
+++ b/src/assets/css/main.css
@@ -364,3 +364,7 @@ br.big {
 .tribute-container .menu-highlighted {
   font-weight: bold;
 }
+
+.honeypot {
+  display:none !important;
+}
diff --git a/src/shared/components/home/signup.tsx b/src/shared/components/home/signup.tsx
index 722f644f..1452ba07 100644
--- a/src/shared/components/home/signup.tsx
+++ b/src/shared/components/home/signup.tsx
@@ -1,3 +1,5 @@
+import { Options, passwordStrength } from "check-password-strength";
+import { I18nKeys } from "i18next";
 import { Component, linkEvent } from "inferno";
 import { T } from "inferno-i18next-dess";
 import {
@@ -10,7 +12,6 @@ import {
 } from "lemmy-js-client";
 import { Subscription } from "rxjs";
 import { i18n } from "../../i18next";
-import { Options, passwordStrength } from "check-password-strength";
 import { UserService, WebSocketService } from "../../services";
 import {
   authField,
@@ -26,7 +27,6 @@ import {
 } from "../../utils";
 import { HtmlTags } from "../common/html-tags";
 import { Icon, Spinner } from "../common/icon";
-import {I18nKeys} from "i18next";
 
 const passwordStrengthOptions: Options<string> = [
   {
@@ -76,6 +76,7 @@ export class Signup extends Component<any, State> {
       show_nsfw: false,
       captcha_uuid: undefined,
       captcha_answer: undefined,
+      honeypot: undefined,
     },
     registerLoading: false,
     captcha: undefined,
@@ -272,6 +273,16 @@ export class Signup extends Component<any, State> {
             </T>
           </div>
         )}
+        <input
+          tabIndex={-1}
+          autoComplete="false"
+          name="a_password"
+          type="text"
+          class="form-control honeypot"
+          id="register-honey"
+          value={this.state.registerForm.honeypot}
+          onInput={linkEvent(this, this.handleHoneyPotChange)}
+        />
         <div class="form-group row">
           <div class="col-sm-10">
             <button type="submit" class="btn btn-secondary">
@@ -371,6 +382,11 @@ export class Signup extends Component<any, State> {
     i.setState(i.state);
   }
 
+  handleHoneyPotChange(i: Signup, event: any) {
+    i.state.registerForm.honeypot = event.target.value;
+    i.setState(i.state);
+  }
+
   handleRegenCaptcha(i: Signup) {
     i.audio = null;
     i.state.captchaPlaying = false;
diff --git a/src/shared/components/post/post-form.tsx b/src/shared/components/post/post-form.tsx
index 7793dd72..40e8e7bc 100644
--- a/src/shared/components/post/post-form.tsx
+++ b/src/shared/components/post/post-form.tsx
@@ -326,6 +326,16 @@ export class PostForm extends Component<PostFormProps, PostFormState> {
               </div>
             </div>
           )}
+          <input
+            tabIndex={-1}
+            autoComplete="false"
+            name="a_password"
+            type="text"
+            class="form-control honeypot"
+            id="register-honey"
+            value={this.state.postForm.honeypot}
+            onInput={linkEvent(this, this.handleHoneyPotChange)}
+          />
           <div class="form-group row">
             <div class="col-sm-10">
               <button
@@ -466,6 +476,11 @@ export class PostForm extends Component<PostFormProps, PostFormState> {
     i.setState(i.state);
   }
 
+  handleHoneyPotChange(i: PostForm, event: any) {
+    i.state.postForm.honeypot = event.target.value;
+    i.setState(i.state);
+  }
+
   handleCancel(i: PostForm) {
     i.props.onCancel();
   }
diff --git a/yarn.lock b/yarn.lock
index 8795f38a..cc5e52e9 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -4915,10 +4915,10 @@ lcid@^1.0.0:
   dependencies:
     invert-kv "^1.0.0"
 
-lemmy-js-client@0.13.0:
-  version "0.13.0"
-  resolved "https://registry.yarnpkg.com/lemmy-js-client/-/lemmy-js-client-0.13.0.tgz#fc15f603a8492e0c2542a3b55fb4df06a182b4fc"
-  integrity sha512-7RBgbd3hOTq8fb+oef3B8U1O1UmIutTI0n+fx0EMHjFIselYwBwHhpSD6/ORtPPMXDY5MS6jiwO5QV7blSQRtA==
+lemmy-js-client@0.13.1-rc.1:
+  version "0.13.1-rc.1"
+  resolved "https://registry.yarnpkg.com/lemmy-js-client/-/lemmy-js-client-0.13.1-rc.1.tgz#e1af4749a5493954a17f87b7b20dcccb8c585f22"
+  integrity sha512-fncCq6Zu8s6GpeCrkmJS8/rqXcyrJ8p8EyWfXiiuZlWkgzOIi+qZjTRnO63wI6DomYwVOjwk7sry4RbOJSdK5Q==
 
 levn@^0.4.1:
   version "0.4.1"