LemmyNet/lemmy-ui
2
0
Fork 0
mirror of https://github.com/LemmyNet/lemmy-ui.git synced 2024-12-23 11:21:26 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #1764 from jsit/fix/vote-button-no-spinners-1761

Browse source 
fix: Fix vote buttons not showing spinners while registering vote #1761
This commit is contained in:
Jay Sitter 2023-07-02 17:39:33 -04:00 committed by GitHub
commit 083d5aa751
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 18 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
src/shared/components/common/vote-buttons.tsx
View file

@ -64,8 +64,6 @@ const handleUpvote = (i: VoteButtons) => {
auth: myAuthRequired(), auth: myAuthRequired(),
}); });
} }
i.setState({ upvoteLoading: false });
}; };
const handleDownvote = (i: VoteButtons) => { const handleDownvote = (i: VoteButtons) => {
@ -86,7 +84,6 @@ const handleDownvote = (i: VoteButtons) => {
auth: myAuthRequired(), auth: myAuthRequired(),
}); });
} }
i.setState({ downvoteLoading: false });
}; };
export class VoteButtonsCompact extends Component< export class VoteButtonsCompact extends Component<
@ -102,6 +99,15 @@ export class VoteButtonsCompact extends Component<
super(props, context); super(props, context);
} }
componentWillReceiveProps(nextProps: VoteButtonsProps) {
if (this.props !== nextProps) {
this.setState({
upvoteLoading: false,
downvoteLoading: false,
});
}
}
render() { render() {
return ( return (
<> <>
@ -172,6 +178,15 @@ export class VoteButtons extends Component<VoteButtonsProps, VoteButtonsState> {
super(props, context); super(props, context);
} }
componentWillReceiveProps(nextProps: VoteButtonsProps) {
if (this.props !== nextProps) {
this.setState({
upvoteLoading: false,
downvoteLoading: false,
});
}
}
render() { render() {
return ( return (
<div className="vote-bar small text-center"> <div className="vote-bar small text-center">