LemmyNet/joinlemmy-site
2
0
Fork 0
mirror of https://github.com/LemmyNet/joinlemmy-site.git synced 2024-11-22 04:11:15 +00:00
Code Issues Projects Releases Wiki Activity

Change instance sort order - revised weight of member counts (#223)

Browse source 
* Changed 'popular' instance sorting to be more evenly distributed, and improve the weighting for user numbers

* Ran prettier on prevoiusly comitted code

* Ran prettier on prevoiusly comitted code

* Modified averageFunc to be a class function instead of const var. Ensured prettier and yarn lint were successfully ran.

* Updated variable names and reverted min_monthly_user const

* Prettier ran, modified generate_translations.mjs only for formatting corrections

* Based on https://github.com/LemmyNet/joinlemmy-site/pull/214#issuecomment-1635522167, revised randomSortOrder to more heavy bias towards popular instances

* Retrigger checks pipeline

* Ran prettier and adding all modified files that prettier touched
This commit is contained in:
Security-Chief-Odo 2023-07-17 06:28:35 -05:00 committed by GitHub
parent 0db6460782
commit 278eff9db8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
src/shared/components/instances.tsx
View file

@ -9,11 +9,12 @@ export class Instances extends Component<any, any> {
super(props, context); super(props, context);
} }
biasedRandom(min, max, bias, i) { biasedRandom(active_users, avg, max) {
// Lets introduce a better bias to random suffle instances list // Lets introduce a better bias to random shuffle instances list
var rnd = Math.random() * (max - min) + min; var influence = 1.25;
var mix = Math.random() * i; var rnd = Math.random() * (max / influence) + active_users;
return rnd * (1 - mix) + bias * mix; var mix = Math.random() * influence;
return rnd * (1 - mix) + avg * mix;
} }
averageFunc(values: any) { averageFunc(values: any) {
@ -43,9 +44,8 @@ export class Instances extends Component<any, any> {
} }
// Use these values for the shuffle // Use these values for the shuffle
const maxMonthlyUsers = Math.max(...values);
const minMonthlyUsers = Math.min(...values);
const avgMonthlyUsers = this.averageFunc(values); const avgMonthlyUsers = this.averageFunc(values);
const maxMonthlyUsers = Math.max(...values);
let recommended2 = recommended let recommended2 = recommended
.map(value => ({ value, sort: Math.random() })) .map(value => ({ value, sort: Math.random() }))
@ -53,15 +53,13 @@ export class Instances extends Component<any, any> {
.map(({ value }) => value); .map(({ value }) => value);
// BIASED sorting for instances, based on the min/max of users_active_month // BIASED sorting for instances, based on the min/max of users_active_month
// weighted to 2/3 of all counts, but more even distribution
let remaining2 = remaining let remaining2 = remaining
.map(i => ({ .map(i => ({
instance: i, instance: i,
sort: this.biasedRandom( sort: this.biasedRandom(
minMonthlyUsers, i.site_info.site_view.counts.users_active_month,
maxMonthlyUsers,
avgMonthlyUsers, avgMonthlyUsers,
0.75, maxMonthlyUsers,
), ),
})) }))
.sort((a, b) => b.sort - a.sort) .sort((a, b) => b.sort - a.sort)